Add Schema validation to transformJsonToXml developer tool
#1216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add ErrorHandler for XML/XSD schema validation errors. * Add Schema validator which retrieves the configured redactions context and validates against the corresponding schema. * Add functionality to output the validation errors in a log file. * Inject and use schema validation when running the transformation process. * Update developer information.
MartinWheelerMT
force-pushed
the
add-schema-validation-to-transform-tool
branch
from
a5a18ae to
c902067
Compare
* Update XmlSchemaValidator to use newDefaultInstance instead
* Update XmlSchemaValidator to use newDefaultInstance instead
* Update XmlSchemaValidator to use newDefaultInstance instead
MartinWheelerMT
force-pushed
the
add-schema-validation-to-transform-tool
branch
from
2d50466 to
a26e9cd
Compare
MartinWheelerMT
changed the title
transformJsonToXml developer tool
ORybak5
reviewed
May 22, 2025
service/src/main/java/uk/nhs/adaptors/gp2gp/transformJsonToXmlTool/XmlSchemaValidator.java
Show resolved
Hide resolved
ORybak5
reviewed
May 22, 2025
service/src/main/java/uk/nhs/adaptors/gp2gp/transformJsonToXmlTool/XmlSchemaValidator.java
Outdated
Show resolved
Hide resolved
ORybak5
reviewed
May 22, 2025
service/src/main/java/uk/nhs/adaptors/gp2gp/transformJsonToXmlTool/XmlSchemaValidator.java
Outdated
Show resolved
Hide resolved
ORybak5
reviewed
May 22, 2025
service/src/main/java/uk/nhs/adaptors/gp2gp/transformJsonToXmlTool/XmlSchemaValidator.java
Outdated
Show resolved
Hide resolved
* Changed logging to `Error` when the schema file could not be loaded. * Renamed parameter `filename` to be more specific about its intent.
ORybak5
reviewed
May 22, 2025
service/src/main/java/uk/nhs/adaptors/gp2gp/transformJsonToXmlTool/XmlSchemaValidator.java
Outdated
Show resolved
Hide resolved
…ontoxmltool` to address checkstyle package name issues
|
|
ORybak5
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
SonarQubeexclusion fortransformJsonToXmlToolas it is a developer only internal validation tool and is not tested currently.Why
The transform tool will report errors if the resultant transform does not pass schema validation. This is a useful step in being able to diagnose problems with any produced transformation
Type of change
Please delete options that are not relevant.
Checklist: